Re: [PATCH 3/6] pylibfdt_tests: Don't depend on built dtbs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On Thu, Nov 11, 2021 at 10:16:30PM -0600, Rob Herring wrote:
> The pylibfdt tests depend on the rest of the tests to build dtbs, but
> are otherwise independent. Modify the test to build dtbs itself so the
> python tests can run standalone.
> 
> This also fixes an intermittent problem with the DT strings section size
> varying depending on how the dtb was built. The test assumed the dtb was
> built with '-H both' option which is pretty much impossible to tell from
> run_tests.sh.
> 
> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>

This breaks "make check" for me.  I think it's relying on there being
an already built dtc in the path, rather than specifically running the
dtc built from the source tree.

======================================================================
ERROR: testAccess (__main__.PyLibfdtRoTests)
Basic sanity check for the FdtRo class
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/dwg/src/dtc/tests/./pylibfdt_tests.py", line 583, in setUp
    dtb = subprocess.run(['dtc', '-O', 'dtb', os.path.join(testsrc, 'test_tree1.dts')],
  File "/usr/lib64/python3.10/subprocess.py", line 501, in run
    with Popen(*popenargs, **kwargs) as process:
  File "/usr/lib64/python3.10/subprocess.py", line 966, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/usr/lib64/python3.10/subprocess.py", line 1842, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'dtc'

----------------------------------------------------------------------

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Device Tree]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux