On Mon, Oct 11, 2021 at 11:56:19AM -0500, Rob Herring wrote:
> On Sun, Oct 10, 2021 at 11:58 PM David Gibson
> <david@xxxxxxxxxxxxxxxxxxxxx> wrote:
> >
> > On Tue, Sep 28, 2021 at 04:23:33PM -0500, Rob Herring wrote:
[snip]
> > > diff --git a/tests/bad-interrupt-map-parent.dts b/tests/bad-interrupt-map-parent.dts
> > > new file mode 100644
> > > index 000000000000..fe88ce2fe76f
> > > --- /dev/null
> > > +++ b/tests/bad-interrupt-map-parent.dts
> > > @@ -0,0 +1,17 @@
> > > +/dts-v1/;
> > > +
> > > +/ {
> > > + interrupt-parent = <&intc>;
> > > + intc: interrupt-controller {
> > > + };
> > > +
> > > + node {
> > > + #address-cells = <0>;
> > > + #interrupt-cells = <1>;
> > > + interrupt-map = <1 &intc 1 2 3>;
> >
> > If you just want to verify the check on the bad parent, shouldn't you
> > have an interrupt-map-mask here?
>
> No, a missing interrupt-map-mask is not an error. Only the wrong
> number of cells is an error. It's treated as all 1s mask if not
> present. So, in interest of having a minimal test, I omitted it.
Ah, sorry, my mistake.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
Attachment:
signature.asc
Description: PGP signature
