Re: [PATCH 2/3] checks: Drop interrupt provider '#address-cells' check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On Tue, Sep 28, 2021 at 04:23:34PM -0500, Rob Herring wrote:
> '#address-cells' is only needed when parsing 'interrupt-map' properties, so
> remove it from the common interrupt-provider test.
> 
> Cc: Andre Przywara <andre.przywara@xxxxxxx>
> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>

Reviewed-by: David Gibson <david@xxxxxxxxxxxxxxxxxxxxx>

(in the context of the previous patch)

> ---
>  checks.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/checks.c b/checks.c
> index d4e7facd7f37..2efa36377e80 100644
> --- a/checks.c
> +++ b/checks.c
> @@ -1581,11 +1581,6 @@ static void check_interrupt_provider(struct check *c,
>  	if (!prop)
>  		FAIL(c, dti, node,
>  		     "Missing #interrupt-cells in interrupt provider");
> -
> -	prop = get_property(node, "#address-cells");
> -	if (!prop)
> -		FAIL(c, dti, node,
> -		     "Missing #address-cells in interrupt provider");
>  }
>  WARNING(interrupt_provider, check_interrupt_provider, NULL);
>  

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Device Tree]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux