On Mon, May 24, 2021 at 11:49:10AM -0400, Tom Rini wrote:
> Clang has -Wself-assign enabled by default under -Wall and so when
> building with -Werror we would get an error here. Inspired by Linux
> kernel git commit a21151b9d81a ("tools/build: tweak unused value
> workaround") make use of the fact that both Clang and GCC support
> casting to `void` as the method to note that something is intentionally
> unused.
>
> Signed-off-by: Tom Rini <trini@xxxxxxxxxxxx>
Applied, thanks.
> ---
> pylibfdt/libfdt.i | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/pylibfdt/libfdt.i b/pylibfdt/libfdt.i
> index 3e09d3a7eedc..51ee8014d17c 100644
> --- a/pylibfdt/libfdt.i
> +++ b/pylibfdt/libfdt.i
> @@ -1009,7 +1009,7 @@ typedef uint32_t fdt32_t;
> }
> $1 = (void *)PyByteArray_AsString($input);
> fdt = $1;
> - fdt = fdt; /* avoid unused variable warning */
> + (void)fdt; /* avoid unused variable warning */
> }
>
> /* Some functions do change the device tree, so use void * */
> @@ -1020,7 +1020,7 @@ typedef uint32_t fdt32_t;
> }
> $1 = PyByteArray_AsString($input);
> fdt = $1;
> - fdt = fdt; /* avoid unused variable warning */
> + (void)fdt; /* avoid unused variable warning */
> }
>
> /* typemap used for fdt_get_property_by_offset() */
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
Attachment:
signature.asc
Description: PGP signature
