On Mon, Oct 12, 2020 at 05:19:44PM +0100, Andre Przywara wrote:
> With -Wsign-compare, compilers warn about a mismatching signedness
> in comparisons in code using the "reservednum" variable.
>
> There is obviously little sense in having a negative number of reserved
> memory entries, so let's make this variable and all its users
> unsigned.
If you change this, then you also need to change from strtol() to
strtoul() at the point this assigned.
>
> Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx>
> ---
> dtc.c | 2 +-
> dtc.h | 2 +-
> flattree.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/dtc.c b/dtc.c
> index bdb3f59..eed69d5 100644
> --- a/dtc.c
> +++ b/dtc.c
> @@ -12,7 +12,7 @@
> * Command line options
> */
> int quiet; /* Level of quietness */
> -int reservenum; /* Number of memory reservation slots */
> +unsigned int reservenum;/* Number of memory reservation slots */
> int minsize; /* Minimum blob size */
> int padsize; /* Additional padding to blob */
> int alignsize; /* Additional padding to blob accroding to the alignsize */
> diff --git a/dtc.h b/dtc.h
> index 511dda1..bebdb22 100644
> --- a/dtc.h
> +++ b/dtc.h
> @@ -35,7 +35,7 @@
> * Command line options
> */
> extern int quiet; /* Level of quietness */
> -extern int reservenum; /* Number of memory reservation slots */
> +extern unsigned int reservenum; /* Number of memory reservation slots */
> extern int minsize; /* Minimum blob size */
> extern int padsize; /* Additional padding to blob */
> extern int alignsize; /* Additional padding to blob accroding to the alignsize */
> diff --git a/flattree.c b/flattree.c
> index 4659afb..3d0204f 100644
> --- a/flattree.c
> +++ b/flattree.c
> @@ -295,7 +295,7 @@ static struct data flatten_reserve_list(struct reserve_info *reservelist,
> {
> struct reserve_info *re;
> struct data d = empty_data;
> - int j;
> + unsigned int j;
>
> for (re = reservelist; re; re = re->next) {
> d = data_append_re(d, re->address, re->size);
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
Attachment:
signature.asc
Description: PGP signature
