On Fri, Sep 25, 2020 at 05:21:54PM +0400, Marc-André Lureau wrote: > Hi > > On Fri, Sep 25, 2020 at 2:40 PM David Gibson > <david@xxxxxxxxxxxxxxxxxxxxx> wrote: > > > > On Mon, Sep 21, 2020 at 12:09:16PM +0400, Marc-André Lureau wrote: > > > Hi > > > > > > On Mon, Sep 21, 2020 at 10:46 AM David Gibson > > > <david@xxxxxxxxxxxxxxxxxxxxx> wrote: > > > > > > > > On Tue, Sep 15, 2020 at 11:27:03PM +0400, marcandre.lureau@xxxxxxxxxx wrote: > > > > > From: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx> > > > > > > > > > > setup.py build_ext is run from top_srcdir with Makefile. > > > > > > > > > > ../pylibfdt will produce output files in parent directory. > > > > > > > > Uh.. can you elaborate a bit on what exactly ends up where, and why > > > > the new behaviour you're setting up is better. > > > > > > > > > ~/src/dtc $ make > > > ... > > > ~/src/dtc $ ls ../pylibfdt > > > _libfdt.cpython-38-x86_64-linux-gnu.so > > > > > > > > > It "escapes" the source directory > > > > Sorry, still not clear to me. Is that the old behaviour or the new? > > It's the current/old behaviour. > > > How does it differ from the other one? > > What I propose will put it again under $(curdir)/pylibfdt instead. > > Apparently this was a regression from commit > 1e4a0928f3b3b827824222572e551a60935607e3. > > Since setup.py is invoked from top-level Makefile location, you > shouldn't have added ../ I guess. Ah! Now I get it. Can you expand the commit message bit to make that clearer. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
Attachment:
signature.asc
Description: PGP signature
