On Mon, Sep 21, 2020 at 05:52:56PM +0100, Andre Przywara wrote: > With -Wsign-compare, compilers warn about a mismatching signedness > in a comparison in fdt_splice_(). > > Since we just established that oldlen is not negative, we can safely > cast it to an unsigned type. > > Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx> Applied, thanks. > --- > libfdt/fdt_rw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libfdt/fdt_rw.c b/libfdt/fdt_rw.c > index 93e4a2b..68887b9 100644 > --- a/libfdt/fdt_rw.c > +++ b/libfdt/fdt_rw.c > @@ -59,7 +59,7 @@ static int fdt_splice_(void *fdt, void *splicepoint, int oldlen, int newlen) > > if ((oldlen < 0) || (soff + oldlen < soff) || (soff + oldlen > dsize)) > return -FDT_ERR_BADOFFSET; > - if ((p < (char *)fdt) || (dsize + newlen < oldlen)) > + if ((p < (char *)fdt) || (dsize + newlen < (unsigned)oldlen)) > return -FDT_ERR_BADOFFSET; > if (dsize - oldlen + newlen > fdt_totalsize(fdt)) > return -FDT_ERR_NOSPACE; -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
Attachment:
signature.asc
Description: PGP signature
