On Tue, Jun 2, 2020 at 11:03 AM Serge Semin <Sergey.Semin@xxxxxxxxxxxxxxxxxxxx> wrote: > On Thu, May 28, 2020 at 06:26:50PM +0930, Joel Stanley wrote: ... > > +#define I2C_TEN_BIT_ADDRESS (1 << 31) > > As Andy neatly pointed out here: > https://lore.kernel.org/lkml/20200527133656.GV1634618@xxxxxxxxxxxxxxxxxx/ > (1 << 31) is UB. Thanks, Serge. Yes, we have to use 1U in the definitions (for 31 is necessary, for the rest is for the sake of consistency). -- With Best Regards, Andy Shevchenko
