Re: [PATCH] checks: Remove warning for I2C_OWN_SLAVE_ADDRESS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



Hi David,

On Thu, 21 May 2020 15:09:14 +1000 David Gibson <david@xxxxxxxxxxxxxxxxxxxxx> wrote:
>
> On Wed, May 20, 2020 at 05:21:34PM +0930, Joel Stanley wrote:
> > dtc does a sanity check on reg properties that they are within the 10
> > bit address range for i2c slave addresses. In the case of multi-master
> > buses the binding may describe an address that the bus will listen on as
> > a device. Do not warn when this flag is set.
> > 
> > This fixes the following build warnings reported by Stephen:
> > 
> > arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts:126.11-130.4:
> >   Warning (i2c_bus_reg): /ahb/apb/bus@1e78a000/i2c-bus@80/ipmb1@10:
> >     I2C bus unit address format error, expected "40000010"
> > arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts:128.3-30:
> >   Warning (i2c_bus_reg): /ahb/apb/bus@1e78a000/i2c-bus@80/ipmb1@10:reg:
> >     I2C address must be less than 10-bits, got "0x40000010"
> > 
> > Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Joel Stanley <joel@xxxxxxxxx>  
> 
> Any document you can give a pointer two explaining the special meaning
> of this bit?
include/dt-bindings/i2c/i2c.h
Is Documentation/devicetree/bindings/i2c/i2c.txt in the kernel tree
sufficient? I2C_OWN_SLAVE_ADDRESS has been in there since the file was
introduced in August 2015.  The actual value has been in
include/dt-bindings/i2c/i2c.h since the same time.

-- 
Cheers,
Stephen Rothwell

Attachment: pgp8cSBGlAQKG.pgp
Description: OpenPGP digital signature


[Index of Archives]     [Device Tree]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux