On Mon, Mar 09, 2020 at 07:29:20PM +1100, David Gibson wrote: > Uhh... I don't think it's accurate to say the valgrind tests don't > test *anything*. They're not checking for leaks, but they're still > checking for use after free, use of uninitialized data and so forth. Ok, indeed, sorry, my fault. I should have said that valgrind tests do not check for memory leaks. > I'm actually not particularly concerned about leaks in dtc, because > it's a strictly short runtime transient process. You can think if it > as using the OS process as a rudimentary pool allocator. Leaks in > libfdt would be a problem... but libfdt doesn't use the allocator at > all, so they're essentially impossible. Between those two is probably > why I never enabled the valgrind leak detector. Ok, I see. As a sidenote, --tool=memcheck is the default option for valgrind so it could be removed but it's not a big deal. -- Arkadiusz Drabczyk <arkadiusz@xxxxxxxxxxxx>
