Re: [PATCH 1/4] libfdt: Fix a few typos

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On Mon, Mar 02, 2020 at 12:02:52PM -0700, Simon Glass wrote:
> Fix 'saftey' and 'additional' typos noticed in the assumption series.
> Reword the ASSUME_NO_ROLLBACK slightly to improve clarity.
> 
> Signed-off-by: Simon Glass <sjg@xxxxxxxxxxxx>
> Suggested-by: David Gibson <david@xxxxxxxxxxxxxxxxxxxxx>

Series applied to master, thanks.

> ---
> 
>  libfdt/libfdt_internal.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/libfdt/libfdt_internal.h b/libfdt/libfdt_internal.h
> index e9913cd..3201678 100644
> --- a/libfdt/libfdt_internal.h
> +++ b/libfdt/libfdt_internal.h
> @@ -58,7 +58,7 @@ static inline struct fdt_reserve_entry *fdt_mem_rsv_w_(void *fdt, int n)
>  
>  /*
>   * Defines assumptions which can be enabled. Each of these can be enabled
> - * individually. For maximum saftey, don't enable any assumptions!
> + * individually. For maximum safety, don't enable any assumptions!
>   *
>   * For minimal code size and no safety, use ASSUME_PERFECT at your own risk.
>   * You should have another method of validating the device tree, such as a
> @@ -121,8 +121,8 @@ enum {
>  	ASSUME_LATEST		= 1 << 2,
>  
>  	/*
> -	 * This assume that it is OK for a failed additional to the device tree
> -	 * due to lack of space or some other problem can skip any rollback
> +	 * This assumes that it is OK for a failed addition to the device tree,
> +	 * due to lack of space or some other problem, to skip any rollback
>  	 * steps (such as dropping the property name from the string table).
>  	 * This is safe to enable in most circumstances, even though it may
>  	 * leave the tree in a sub-optimal state.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Device Tree]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux