On 1/22/20 12:00 PM, Alexandre Torgue wrote: > Hi > > On 1/20/20 7:17 PM, Steve McIntyre wrote: >> On Fri, Jan 17, 2020 at 08:43:23AM -0600, Rob Herring wrote: >>> On Fri, Jan 17, 2020 at 6:26 AM David Gibson >>> <david@xxxxxxxxxxxxxxxxxxxxx> wrote: >> >> ... >> >>>> What might be better would be to have a dtc option which force appends >>>> an extra .dts to the mail .dts compiled. You can then put an overlay >>>> template in that file, something like: >>>> >>>> &{/} { >>>> linux,build-info = /incbin/ "build-info.txt; >>>> } >>> >>> I like this suggestion either as an include another dts file or an >>> overlay. The latter could be useful as a way to maintain current dtb >>> files while splitting the source files into base and overlay dts >>> files. >> >> ACK, that sounds like it could be helpful. >> >>> But no, let's not prepend this with 'linux'. It's not a property >>> specific for Linux to consume. >> >> Right. We might be seeing the data coming through from U-Boot (or any >> other random bootloader) too. >> >> Cheers, >> > > Thanks for reviews. I gonna prepare a V2 with David proposition (to use overlay format) by keeping in mind not to modify existing dts(i) files. > > Remaining questions are: > > 1- "build-info" or "linux,build-info"? IMO, If information is > "generic" then first one should be used. I would prefer build-info. The data may be generated by a non-linux build environment, such as uboot. > 2- Looking at Franck proposition[1] some years ago and objections on > it, do you think that this one could accepted ? I think that with the few small changes suggested in this thread, that the old objections are not relevant to your version. > > regards > Alex > > [1] https://lore.kernel.org/linux-arm-kernel/550A42AC.8060104@xxxxxxxxx/ > > > > >