On Tue, Jan 21, 2020 at 08:37:34AM -0700, Ian Lepore wrote: > On Tue, 2020-01-21 at 13:05 +1100, David Gibson wrote: > > > Given that dts files are run through the C preprocessor before being > > > fed to dtc, the build script could use the '-include' flag to force- > > > include a fragment containing generated build info without any need to > > > modify existing dts files. > > > > Uh... maybe. -include will essentially prepend the forced file, which > > is a bit awkward for our purposes. It means that the prepended file > > would need the /dts-v1/ tag, and we couldn't have it in the main files > > which would be a bit confusing. I think it would also cause problems > > with any /memreserve/ tags and means that the main tree could in > > theory overwrite the build information which we don't necessarily > > want. > > Oh. I thought I had seen a proposal or patch fly by here recently that > allowed multiple /dts-v1/ tags without any warnings, specifically to > wish away any problems with what order things might get included. If > that was just some kind of fever-dream, then I guess: nevermind. :) Multiple /dts-v1/ tags are allowed, but they all have to be at the top of the logical file (once includes are resolved) before anything else. That wouldn't be the case here. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
Attachment:
signature.asc
Description: PGP signature
