Re: [PATCH] tests: default to 'cc' if CC not set

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On Mon, Nov 18, 2019 at 10:23:25AM -0500, Ed Maste wrote:
> On Fri, 15 Nov 2019 at 17:20, David Gibson <david@xxxxxxxxxxxxxxxxxxxxx> wrote:
> >
> > On Fri, Nov 15, 2019 at 03:51:08PM +0000, Ed Maste wrote:
> > > From: Ed Maste <emaste@xxxxxxxxxxx>
> > >
> > > By default FreeBSD does not have 'gcc' in the PATH (on common platforms).
> > > As on Linux 'cc' is available as a link to the default compiler (Clang or
> > > GCC), so just use 'cc'.
> > >
> > > Signed-off-by: Ed Maste <emaste@xxxxxxxxxxx>
> >
> > Applied, thanks.  This is also more consistent, since I believe for
> > the actual build we just use make's default CC, which is generally
> > "cc".
> 
> Thanks. It seems these are still visible in the
> pub/scm/utils/dtc/dtc.git repo; once they are I'll rebase and post the
> addition of .cirrus.yml for review.

Oops, I pushed to my github staging repo, but forgot to push to the
master korg repository.  Done now.

> I still need to address the gnu_printf attribute for FreeBSD - for now
> I've just reverted 588a29ff2e locally.

Yeah, I was always a bit worred about 588a29ff2e, but it also does
address a real warning, so I'm not sure what to do about it at this
stage.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Device Tree]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux