Re: [PATCH v2 2/6] libfdt: Allow control of checks in fdt.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On Thu, Oct 24, 2019 at 09:32:55PM -0600, Simon Glass wrote:
> Hi David,
> 
> On Tue, 3 Sep 2019 at 22:33, David Gibson <david@xxxxxxxxxxxxxxxxxxxxx> wrote:
> >
> > On Thu, Aug 01, 2019 at 01:13:59PM -0600, Simon Glass wrote:
> > > This core file provides checks for the header and for traversal of the
> > > device tree. Allow these checks to be disabled to reduce code size.
> > >
> > > Signed-off-by: Simon Glass <sjg@xxxxxxxxxxxx>
> >
> > Fwiw, these would probably have been easier to review if split up by
> > check flag, rather than split by file.  But I realize it's probably a
> > big pain to reorganize that way, so I won't insist on it.
> 
> Long pause on this side due to other things going on, but I am finally
> back for another round of this.
> 
> It's pretty quick to change as you suggest, so I have done it. I agree
> it is better.
> 
> It makes the change log for each patch a big wonky of course.

Hrm, I would have thought it would make them more coherent, actually.


In anycase, I'm travelling right now (KVM Forum, then holidays).  So,
when I'll be able to get to this is even less predictable than usual,
sorry.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Device Tree]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux