Re: [PATCH v2 07/10] util: use gnu_printf format attribute

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On Wed, Oct 09, 2019 at 02:20:22PM +0400, marcandre.lureau@xxxxxxxxxx wrote:
> From: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>
> 
> dtc uses non-portable formats. Using gnu_printf attributes (for
> warnings) in combination with __USE_MINGW_ANSI_STDIO allows to build
> for win32.
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>

Applied, although I wonder if we should be removing the use of
non-portable formats instead.  Trying to maintain portability is a
real game of whack-a-mole :/.

> ---
>  util.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/util.h b/util.h
> index ca5cb52..347b305 100644
> --- a/util.h
> +++ b/util.h
> @@ -12,7 +12,7 @@
>   */
>  
>  #ifdef __GNUC__
> -#define PRINTF(i, j)	__attribute__((format (printf, i, j)))
> +#define PRINTF(i, j)	__attribute__((format (gnu_printf, i, j)))
>  #define NORETURN	__attribute__((noreturn))
>  #else
>  #define PRINTF(i, j)

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Device Tree]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux