Re: [PATCH] fdtoverlay: Return non-zero exit code if overlays can't be applied

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On Wed, Oct 09, 2019 at 12:33:52PM +0000, Valter Minute wrote:
> From: Valter Minute <valter.minute@xxxxxxxxxxx>
> 
> At present the tool terminates its execution if one of the overlays passed
> as command-line arguments can't be successfully read or applied, but the exit
> code of the process is zero, making failures hard to detect inside scripts.
> 
> Signed-off-by: Valter Minute <valter.minute@xxxxxxxxxxx>

Applied, thanks.

> ---
>  fdtoverlay.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fdtoverlay.c b/fdtoverlay.c
> index 8a1d11b..5350af6 100644
> --- a/fdtoverlay.c
> +++ b/fdtoverlay.c
> @@ -110,7 +110,6 @@ static int do_fdtoverlay(const char *input_filename,
>  			(unsigned long)buf_len, fdt_totalsize(blob));
>  		goto out_err;
>  	}
> -	ret = 0;
>  
>  	/* allocate blob pointer array */
>  	ovblob = xmalloc(sizeof(*ovblob) * argc);

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Device Tree]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux