Hi
On Wed, Oct 9, 2019 at 8:03 AM David Gibson <david@xxxxxxxxxxxxxxxxxxxxx> wrote:
>
> On Mon, Oct 07, 2019 at 11:18:04PM +0400, marcandre.lureau@xxxxxxxxxx wrote:
> > From: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>
> >
> > Fixes:
> > ResourceWarning: unclosed file <_io.BufferedReader
> > name='test_tree1.dtb'>
>
> Fixing the warning is good, regardless of meson.
>
> I'm a little confused as to why we got the warning in the first place,
> though. Shouldn't the file be implicitly closed when the file object
> is destructed?
I can't find a good explanation at hand, or on stackoverflow.
Up to you if you prefer to drop the patch
> >
> > Signed-off-by: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>
> > ---
> > tests/pylibfdt_tests.py | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/tests/pylibfdt_tests.py b/tests/pylibfdt_tests.py
> > index 42f31ba..509cf14 100644
> > --- a/tests/pylibfdt_tests.py
> > +++ b/tests/pylibfdt_tests.py
> > @@ -64,7 +64,8 @@ def _ReadFdt(fname):
> > Returns:
> > Fdt bytearray suitable for passing to libfdt functions
> > """
> > - return libfdt.Fdt(open(fname, mode='rb').read())
> > + with open(fname, mode='rb') as f:
> > + return libfdt.Fdt(f.read())
> >
> > class PyLibfdtBasicTests(unittest.TestCase):
> > """Test class for basic pylibfdt access functions
> > @@ -573,7 +574,8 @@ class PyLibfdtRoTests(unittest.TestCase):
> >
> > def setUp(self):
> > """Read in the device tree we use for testing"""
> > - self.fdt = libfdt.FdtRo(open('test_tree1.dtb', mode='rb').read())
> > + with open('test_tree1.dtb', mode='rb') as f:
> > + self.fdt = libfdt.FdtRo(f.read())
> >
> > def testAccess(self):
> > """Basic sanity check for the FdtRo class"""
>
> --
> David Gibson | I'll have my music baroque, and my code
> david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
> | _way_ _around_!
> http://www.ozlabs.org/~dgibson
