On Wed, Oct 09, 2019 at 02:18:42PM +1100, David Gibson wrote:
> On Mon, Oct 07, 2019 at 11:17:59PM +0400, marcandre.lureau@xxxxxxxxxx wrote:
> > From: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>
> >
> > meson runs out-of-tree, add absolute path location where necessary.
>
> I think this change is a good idea, even if we don't move to meson
> long term. I've long thought that the dtc make & test stuff had an
> inconvenient dependence on exactly where it was run, I just haven't
> had the time to fix it.
>
> The only downside is it makes the output of run_tests.sh a bit less
> readable since a bunch of those SRCDIR paths are shown there as well
> as used internally.
>
> If you can think of a way to avoid that, that'd be great, but if not
> (and I can't think of one quickly) it's not a showstopper.
Oh, one other nit.
> > diff --git a/tests/incbin.c b/tests/incbin.c
> > index fd02609..8ed70d2 100644
> > --- a/tests/incbin.c
> > +++ b/tests/incbin.c
> > @@ -52,7 +52,11 @@ int main(int argc, char *argv[])
> >
> > test_init(argc, argv);
> >
> > - incbin = load_file("incbin.bin", &len);
> > + if (argc != 3)
> > + FAIL("Missing arguments");
> > +
> > + incbin = load_file(argv[2], &len);
> > + argc--;
> > fdt = load_blob_arg(argc, argv);
I don't love this approach of mangling argc here. I'd prefer to call
load_blob() rather than load_blob_arg() here, even if it's a little
more verbose.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
Attachment:
signature.asc
Description: PGP signature
