David Gibson's on May 2, 2019 2:22 pm: > On Tue, Apr 30, 2019 at 06:15:35PM +1000, Nicholas Piggin wrote: >> Searching for duplicate names scales O(n^2) with the number of names >> added to a fdt, which can cause a noticable slowdown with larger device >> trees and very slow CPU cores. >> >> Add FDT_CREATE_FLAG_FAST that allow the caller to trade fdt size for >> speed in the creation process. > > "FAST" is terribly non-specific, I'd prefer to be explict about what > this does. Maybe "SKIP_NAME_DEDUP"? It was kind of intended to be non-specific. I don't know that the caller should ever really have know that it's specifically for name de-duplication or have to think too hard about it. Example: you could add more extensive integrity checks and exclude them with this flag too. Example: you might use some other data structure that speeds up deduplication enough you could restore it even with this flag. Your call though, I can rename it. Thanks, Nick
