On Fri, Mar 29, 2019 at 12:13:56PM +1100, David Gibson wrote: > On Wed, Mar 27, 2019 at 03:15:52PM +0900, AKASHI Takahiro wrote: > > This function will append an address range property using parent node's > > "#address-cells" and "#size-cells" properties. > > > > It will be used in implementing kdump with kexec_file_load system call > > at linux kernel for arm64 once it is merged into kernel tree. > > > > Signed-off-by: AKASHI Takahiro <takahiro.akashi@xxxxxxxxxx> > > I've applied this, fixing a bug in the testcase along the way. > > [snip] > > + /* 2. default property name */ > > + addr = TEST_MEMREGION_ADDR; > > + if (xac > 1) > > + addr += TEST_MEMREGION_ADDR_HI; > > + size = TEST_MEMREGION_SIZE; > > + if (xsc > 1) > > + size += TEST_MEMREGION_SIZE_HI; > > + > > + err = fdt_appendprop_addrrange(fdt, 0, offset, NULL, addr, size); > > + if (err) > > + FAIL("Failed to set \"reg\"(default): %s", fdt_strerror(err)); > > Treating a NULL name as "reg" was removed in a previous iteration but > you're still testing it here. Right, this part of test case should be removed. Is the rest of the patch Okay? -Takahiro Akashi > > -- > David Gibson | I'll have my music baroque, and my code > david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ > | _way_ _around_! > http://www.ozlabs.org/~dgibson