On 2/5/19 8:28 PM, AKASHI Takahiro wrote: > Rob, Frank, > > Ping. > Can you please review this patch? > It is crucial for my submitting a kernel patch for kdump on arm64. It looks like David sent review comments for v2 shortly after your request for review. I don't have any comments contrary to David's, so I will have to look at v3. -Frank > > Thanks, > -Takahiro Akashi > > On Thu, Jan 24, 2019 at 07:20:47PM +0900, AKASHI Takahiro wrote: >> This function will be used in the future, once merged into linux kernel >> tree, to implement kexec_file_load(kdump) for arm64. >> See my kernel patch[1]. >> >> # I think "FSF's address" be removed from the license claim, >> # but I keep it unchanged for consistency with other sources. >> >> [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2018-November/612641.html >> >> Changes in v2 (Jan 24, 2019) >> * change interface semantics based on David's suggestion, from 'set' >> to 'append' >> * So the function name was also changed. >> >> AKASHI Takahiro (2): >> libfdt: add fdt_append_addrrange() >> tests: add fdt_appendprop_addrrange() test >> >> libfdt/fdt_addresses.c | 43 ++++++++++++++ >> libfdt/libfdt.h | 37 ++++++++++++ >> tests/.gitignore | 1 + >> tests/Makefile.tests | 1 + >> tests/appendprop_addrrange.c | 108 +++++++++++++++++++++++++++++++++++ >> tests/run_tests.sh | 5 ++ >> tests/testdata.h | 6 ++ >> tests/tests.h | 3 + >> tests/testutils.c | 58 +++++++++++++++++++ >> 9 files changed, 262 insertions(+) >> create mode 100644 tests/appendprop_addrrange.c >> >> -- >> 2.19.1 >> >
