On Sun, Feb 3, 2019 at 7:58 PM David Gibson <david@xxxxxxxxxxxxxxxxxxxxx> wrote:
>
> On Tue, Jan 29, 2019 at 10:31:10AM -0600, Rob Herring wrote:
> > The generated __symbols__, __local_fixups__ and __fixups__ nodes don't
> > have markers, so we can't generate YAML output for them. We don't care
> > about them for YAML output anyways, so just skip over them.
>
> This seems bogus - it makes assumptions about how the yaml output will
> be used, and means it doesn't really get the same output as other
> modes.
The YAML output is *special* because we said it is an intermediate
format only for validation.
> The __symbols__, __local_fixups__ and __fixups__ nodes have a known
> format, which means we shouldn't need input from the front end about
> how to interpret them. Or to look at it another way, there's no
> reason the code which generates them can't generate the type markers.
Guess I'll resurrect my code to add markers on the input side...
Another concern I have is the property names within these nodes could
falsely match schema. For example, a schema could fail when 'reg' is a
string:
reg: a-node {
};
(I wonder how/if the checks avoid this?)
I guess the validator can strip __symbols__, __local_fixups__ and __fixups__.
Rob
