On Tue, Nov 20, 2018 at 01:13:48PM +0100, Lumir Balhar wrote: > Hello. > > Could we please finish this? Yes, sorry. I did some preliminary changes aiming towards simultaneous testing of Python2 and Python3, but then got side tracked before completing it. > I did a rebase of all my patches to the top of current master branch. My py3 > branch is available here: https://github.com/frenzymadness/dtc/ and all > patches are attached. Thanks. > When I test it with Python 2 or Python 3, everything works. Python version > has to be specified by environment variable PYTHON in order to change the > default (python2). > > $ make check > DEP tests/dumptrees.c > DEP tests/trees.S > DEP tests/testutils.c > DEP tests/value-labels.c > … > Basic sanity check for the FdtRo class ... ok > testCreate (__main__.PyLibfdtSwTests) ... ok > > ---------------------------------------------------------------------- > Ran 35 tests in 0.004s > > OK > ********** TEST SUMMARY > * Total testcases: 1826 > * PASS: 1826 > * FAIL: 0 > * Bad configuration: 0 > * Strange test result: 0 > ********** > > $ PYTHON=python3 make check > DEP tests/dumptrees.c > DEP tests/trees.S > DEP tests/testutils.c > DEP tests/value-labels.c > … > ********** TEST SUMMARY > * Total testcases: 1790 > * PASS: 1790 > * FAIL: 0 > * Bad configuration: 0 > * Strange test result: 0 > ********** So, the reason many less tests are run in this case is that the Python3 setup.py uses a different name for the extension moule .so. That means that the test scripts think there isn't Python support and doesn't run those tests. We need to at least fix that before this is ready to go. I've merged some bits and pieces from your series, and I've made a few other changes to get this closer. I hope this time I can actually get to the rest soon. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
Attachment:
signature.asc
Description: PGP signature
