Re: [PATCH] Added test cases for target references

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On Tue, Sep 25, 2018 at 09:32:37PM +0200, Fredrik Markstrom wrote:
> This commit adds test cases for commits "Correct overlay syntactic
> sugar for generating target-path fragments" and "Merge nodes with
> local target label references".
> 
> It verifies that target path references are not resolved locally and
> that target label references that can be resolved locally are.
> 
> Signed-off-by: Fredrik Markstrom <fredrik.markstrom@xxxxxxxxx>
> ---
> 
> This is a humble first try, feedback on what we need more and how it
> should be done are most welcome. The options are infinite.

Looks reasonable, I've applied it.  There were some whitespace
problems in the patch, not sure if that was in the original, or if
it's been mangled by your mailer.  Anyway I've fixed that up in the merge.

> 
>  tests/overlay_overlay_local_merge.dts | 31 +++++++++++++++++++++++++++
>  tests/run_tests.sh                    |  5 +++++
>  2 files changed, 36 insertions(+)
>  create mode 100644 tests/overlay_overlay_local_merge.dts
> 
> diff --git a/tests/overlay_overlay_local_merge.dts b/tests/overlay_overlay_local_merge.dts
> new file mode 100644
> index 0000000..b926820
> --- /dev/null
> +++ b/tests/overlay_overlay_local_merge.dts
> @@ -0,0 +1,31 @@
> +/*
> + * Copyright (c) 2016 NextThing Co
> + * Copyright (c) 2016 Free Electrons
> + * Copyright (c) 2016 Konsulko Inc.
> + *
> + * SPDX-License-Identifier:	GPL-2.0+
> + */
> +
> +/dts-v1/;
> +/plugin/;
> +
> +&test {
> +      parent: new-node {
> +      	     parent-property;
> +      };

Spaces instead of / as well as tabs above.

> +};
> +
> +&parent {
> +	new-merged-property;
> +	new-merged-node {
> +		new-property;
> +	};
> +};
> +
> +&{/} {
> +	new-root-node {
> +		new-root-node-property;
> +	};
> +};
> +
> +

Unnecessary trailing blank lines.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Device Tree]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux