Re: [PATCH] dtc: trivial '-I fs -O dts' test

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On Mon, Sep 03, 2018 at 10:50:36AM +0200, Greg Kurz wrote:
> Some recent changes caused '-I fs -O dts' to crash instantly when
> emitting the first property holding actual data, ie, coming from
> a non-empty file. This got fixed already by another patch.
> 
> This simply adds a test for the original problem.
> 
> Signed-off-by: Greg Kurz <groug@xxxxxxxx>

Thanks, applied, although I hope to replace it soon with a somewhat
more involved test of -I fs mode.

> ---
>  tests/run_tests.sh |    5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/tests/run_tests.sh b/tests/run_tests.sh
> index 7348c9c7fff0..e240356f6ba1 100755
> --- a/tests/run_tests.sh
> +++ b/tests/run_tests.sh
> @@ -448,6 +448,11 @@ libfdt_tests () {
>  
>      run_test check_header test_tree1.dtb
>  
> +    rm -rf fstree
> +    mkdir fstree
> +    echo -n "foo" > fstree/non_empty_prop
> +    run_dtc_test -I fs -O dts fstree
> +
>      # check full tests
>      for good in test_tree1.dtb; do
>  	run_test check_full $good
> 

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Device Tree]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux