Hi Lumir
On 6 August 2018 at 00:32, Lumir Balhar <lbalhar@xxxxxxxxxx> wrote:
> Hello.
>
> On 07/16/2018 01:34 AM, Simon Glass wrote:
>>
>> Hi,
>>
>> On 12 July 2018 at 08:10, <frenzy@xxxxxxxxx> wrote:
>>>
>>> From: Lumir Balhar <lbalhar@xxxxxxxxxx>
>>>
>>> When some warning appears in test result, "ok" is still
>>> at the end of the line but without three dots.
>>>
>>> Signed-off-by: Lumir Balhar <lbalhar@xxxxxxxxxx>
>>> ---
>>> tests/run_tests.sh | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/tests/run_tests.sh b/tests/run_tests.sh
>>> index 715fa19..0b537e6 100755
>>> --- a/tests/run_tests.sh
>>> +++ b/tests/run_tests.sh
>>> @@ -903,7 +903,7 @@ pylibfdt_tests () {
>>> # and the summary line for total tests (e.g. 'Ran 17 tests in
>>> 0.002s').
>>> # We could add pass + fail to get total tests, but this provides a
>>> useful
>>> # sanity check.
>>
>> Can you please update the comment line as well? You should mention the
>> three dots and perhaps show an example.
>
> I don't understand you here. Why should I mention the three dots in the
> comment when they are no more used in check of passed test?
>
> Or you mean something like: "Do not add three dots here because when a
> warning appears, there might be a newline character between three dots and
> the 'ok'."
That sounds OK to me. I don't see any warnings so it works for me
without this patch.
>
> But IMHO it seems unnecessary to comment something I removed.
Well I'l leave this to David, but I'd prefer to have the comment.
>
>>
>>> - pass_count=$(grep "\.\.\. ok$" $TMP | wc -l)
>>> + pass_count=$(grep "ok$" $TMP | wc -l)
>>> fail_count=$(grep "^ERROR: " $TMP | wc -l)
>>> total_tests=$(sed -n 's/^Ran \([0-9]*\) tests.*$/\1/p' $TMP)
>>> cat $TMP
>>> --
>>> 2.17.1
>>>
Regards,
Simon
--
To unsubscribe from this list: send the line "unsubscribe devicetree-compiler" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
