Re: [PATCH v2 2/3] Make next_type_marker and type_marker_length helpers public

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On Thu, Aug 2, 2018 at 1:04 AM David Gibson <david@xxxxxxxxxxxxxxxxxxxxx> wrote:
>
> On Mon, Jul 30, 2018 at 09:57:36PM -0600, Rob Herring wrote:
> > Make next_type_marker and type_marker_length available to other users of
> > TYPE_* markers.
> >
> > Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
>
> So, I'm find with exposing these, but I'd like some details changed:
>
> > ---
> >  dtc.h        | 16 ++++++++++++++++
> >  treesource.c | 16 ----------------
>
> I don't see a good case for making these inlines.  I think it would be
> better to move them to data.c (since they're helpers pertaining to
> data objects) and expose them as externs.

Sure. I really only need type_marker_length exposed in that case.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree-compiler" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux