Hi David, On 8 July 2018 at 23:05, David Gibson <david@xxxxxxxxxxxxxxxxxxxxx> wrote: > On Sat, Jul 07, 2018 at 01:57:19PM -0600, Simon Glass wrote: >> At present this function appears to copy only the data before the struct >> region and the data in the string region. It does not seem to copy the >> struct region itself. >> >> >From the arguments of this function it seems that it should support fdt >> and buf being different. This patch attempts to fix this problem. >> >> Signed-off-by: Simon Glass <sjg@xxxxxxxxxxxx> >> --- >> >> Changes in v5: >> - Add new patch to copy the struct region in fdt_resize() > > Ouch. This was a pretty unsubtle bug to have been there all along. > > This inspired me to make a testcase which would actually catch this, > and that in turn found an additional bug. I've merged this patch > along with the new test and extra bugfix. Thanks for that. I did think about having a go at new tests, etc., but figured that it would be easier if you did it! Regards, Simon -- To unsubscribe from this list: send the line "unsubscribe devicetree-compiler" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
