The return value is not actually mutable, so it seems more correct to
return bytes rather than a bytearray.
Suggested-by: David Gibson <david@xxxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Simon Glass <sjg@xxxxxxxxxxxx>
---
Changes in v4:
- Use bytes() instead of str() which should also work in Python 3
Changes in v3: None
pylibfdt/libfdt.i | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/pylibfdt/libfdt.i b/pylibfdt/libfdt.i
index 2c104ac..170005f 100644
--- a/pylibfdt/libfdt.i
+++ b/pylibfdt/libfdt.i
@@ -365,7 +365,7 @@ class Fdt:
quiet: Errors to ignore (empty to raise on all errors)
Returns:
- Value of property as a bytearray, or -ve error number
+ Value of property as a string of bytes, or -ve error number
Raises:
FdtError if any error occurs (e.g. the property is not found)
@@ -374,7 +374,8 @@ class Fdt:
quiet)
if isinstance(pdata, (int)):
return pdata
- return bytearray(pdata[0])
+ # Use bytes() rather than string(). This works on both Python 2 and 3
+ return bytes(pdata[0])
def get_phandle(self, nodeoffset):
"""Get the phandle of a node
--
2.17.1.1185.g55be947832-goog
--
To unsubscribe from this list: send the line "unsubscribe devicetree-compiler" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
