Re: [PATCH 06/12] Consolidate utilfdt_read_len() variants

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On 26 March 2018 at 07:25, David Gibson <david@xxxxxxxxxxxxxxxxxxxxx> wrote:
> There are no less than _four_ variants on utilfdt_read() which is a bit
> excessive.  The _len() variants are particularly pointless, since we can
> achieve the same thing with very little extra verbosity by using the usual
> convention of ignoring return parameters if they're NULL.  So, get rid of
> them (we keep the shorter names without _len, but add now-optional len
> parameters).
>
> Signed-off-by: David Gibson <david@xxxxxxxxxxxxxxxxxxxxx>
> ---
>  fdtdump.c         |  2 +-
>  fdtget.c          |  2 +-
>  fdtoverlay.c      |  4 ++--
>  fdtput.c          |  2 +-
>  tests/testutils.c |  2 +-
>  util.c            | 21 +++++----------------
>  util.h            | 20 ++++----------------
>  7 files changed, 15 insertions(+), 38 deletions(-)

Reviewed-by: Simon Glass <sjg@xxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe devicetree-compiler" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux