Re: [PATCH dtc] checks: Print duplicate node name instead of parent name

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On Tue, Mar 27, 2018 at 02:13:31PM +0200, Geert Uytterhoeven wrote:
> When refactoring node path printing, the code checking for duplicate
> node names was accidentally changed to print the name of the parent
> node, instead of the name of the duplicated child node.
> 
> Fixes: 88960e3989073207 ("checks: centralize printing of node path in check_msg")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Applied, thanks.

> ---
> Also applies to Linux' scripts/dtc/checks.c.
> ---
>  checks.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/checks.c b/checks.c
> index 1e6a88c81a998415..e6a38a87cc7d9aac 100644
> --- a/checks.c
> +++ b/checks.c
> @@ -255,7 +255,7 @@ static void check_duplicate_node_names(struct check *c, struct dt_info *dti,
>  		     child2;
>  		     child2 = child2->next_sibling)
>  			if (streq(child->name, child2->name))
> -				FAIL(c, dti, node, "Duplicate node name");
> +				FAIL(c, dti, child2, "Duplicate node name");
>  }
>  ERROR(duplicate_node_names, check_duplicate_node_names, NULL);
>  

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Device Tree]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux