Re: [PATCH 2/5] annotations: Add position information to various calls

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On Tue, Jan 9, 2018 at 12:16 AM, Julia Lawall <julia.lawall@xxxxxxx> wrote:
>
>
> On Mon, 8 Jan 2018, Rob Herring wrote:
>
>> On Mon, Jan 8, 2018 at 7:36 AM, Julia Lawall <Julia.Lawall@xxxxxxx> wrote:
>> > Builds on a patch proposed by Frank Rowand:
>> >
>> > https://www.mail-archive.com/devicetree-compiler@xxxxxxxxxxxxxxx/msg00372.html
>>
>> Better to just put the details here and keep Frank's S-o-b if
>> significant parts he wrote.
>>
>> > Added NULL position argument in a few new places in dtc-parser.tab.c (1)
>> > and livetree.c (3).
>>
>> I think this patch should probably be split into what's needed to keep
>> track of the source position and the annotating dts files part. Mainly
>> I say this because I'm interested in changing the checks to print the
>> dts position (if available) instead of the output file.
>
> Thanks for the feedback.  I'm not sure to understand the last sentence.  I
> thought the code was printing the original position of things?

No, the information was lost by the time checks run as they only have
livetree node and prop structs. See my patch I Cc'ed you on. Currently
the checks just print the dtb file with no position information though
typically they print the full node path. You have to manually find the
node in the source files which is not exact as you can only really
search for the basename.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree-compiler" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux