Re: columns

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On Sat, Jan 06, 2018 at 05:43:20PM +0100, Julia Lawall wrote:
> Hello,
> 
> I have been working with Frank Rowand on a v7 of file and line number
> annotations in the -O dts output of the device tree compiler.
> 
> I wanted to make an --annotate-full option that would print the full
> filename, and starting and ending line and column numbers.
> 
> The following commit:
> 
> commit 728c5e87c655c17c2fbc1d5386b12ff328e0fc76
> Author: David Gibson <david@xxxxxxxxxxxxxxxxxxxxx>
> Date:   Tue Dec 8 14:24:42 2009 +1100
> 
> extends the position mechanism with columns, but considers a tab to be 8
> column.  Would it be ok to drop this feature?  I have the impression that
> counting 1 column for a tab would be more useful for actually finding the
> referenced code.

Hrm.  I set it up that way initially so that the reported columns
would match what shows up inside an editor (e.g. emacs
'column-number-mode').

So, I think I'll need to see a more developed case for why not
expanding tabs this way is preferable before making the change.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Device Tree]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux