On Mon, Nov 20, 2017 at 11:20:31AM -0600, Rob Herring wrote: > On Mon, Nov 20, 2017 at 11:12 AM, Grant Likely > <grant.likely@xxxxxxxxxxxx> wrote: > > From: Grant Likely <grant@xxxxxxxxxxxxxxxxxxxxxxxxx> > > Ummm? > > > Commit 737b2df3, "overlay: Add syntactic sugar version of overlays" > > introduced an empty rule for "devicetree" that created ambiguities in > > the grammar and causes the following warning: > > > > BISON dtc-parser.tab.c > > dtc-parser.y: warning: 3 shift/reduce conflicts [-Wconflicts-sr] > > > > Fix the grammar by explicitly testing for the condition the > > new overlay grammar wants to use. This means duplicating a very small > > amount of grammar processing code, but the alternative seems to be a > > more invasive reorganization of the devicetree rule. Better to fix it > > this way now and save the reorg for a separate patch > > Missing period. I fixed up both of these in my tree. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
Attachment:
signature.asc
Description: PGP signature