Re: [PATCH] Fix ambiguous grammar for devicetree rule

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On Mon, Nov 20, 2017 at 5:20 PM, Rob Herring <robh@xxxxxxxxxx> wrote:
> On Mon, Nov 20, 2017 at 11:12 AM, Grant Likely
> <grant.likely@xxxxxxxxxxxx> wrote:
>> From: Grant Likely <grant@xxxxxxxxxxxxxxxxxxxxxxxxx>
>
> Ummm?

New Linux VM; forgot to do the "git config user.email" step. Bonus
points to there person who figures out my computer naming scheme.

>
>> Commit 737b2df3, "overlay: Add syntactic sugar version of overlays"
>> introduced an empty rule for "devicetree" that created ambiguities in
>> the grammar and causes the following warning:
>>
>>          BISON dtc-parser.tab.c
>>   dtc-parser.y: warning: 3 shift/reduce conflicts [-Wconflicts-sr]
>>
>> Fix the grammar by explicitly testing for the condition the
>> new overlay grammar wants to use. This means duplicating a very small
>> amount of grammar processing code, but the alternative seems to be a
>> more invasive reorganization of the devicetree rule. Better to fix it
>> this way now and save the reorg for a separate patch
>
> Missing period.

thx.

>
>>
>> Signed-off-by: Grant Likely <grant.likely@xxxxxxx>
>> Cc: Pantelis Antoniou <pantelis.antoniou@xxxxxxxxxxxx>
>> Cc: David Gibson <david@xxxxxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe devicetree-compiler" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux