Hi David, On 20 August 2017 at 18:17, David Gibson <david@xxxxxxxxxxxxxxxxxxxxx> wrote: > On Sat, Aug 19, 2017 at 11:18:00AM -0600, Simon Glass wrote: >> When calling libfdt functions which are not supported by the Fdt class it >> is necessary to get direct access to the device tree data. At present this >> requries using the internal _fdt member. Add a new method to provide >> public access to this. >> >> Signed-off-by: Simon Glass <sjg@xxxxxxxxxxxx> > > I've applied patches 1-6 already. > > This looks fine, except I'm dubious about the name. "get_fdt" from an > fdt object seems a bit.. tautological? How about "as_bytestring"? Well, sure it is. It is the only way to get something that can be passed to the libfdt function. So as_bytestring() seems a bit obscure, even though it is more descriptive. I would suggest get_blob() except we don't really use that name in libfdt.h. I will have a think and then send v2. Regards, Simon -- To unsubscribe from this list: send the line "unsubscribe devicetree-compiler" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
