Re: [PATCH 2/7] pylibfdt: Allow building to be disabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On 26 Mar 2017 13:06, Simon Glass wrote:
> --- a/Makefile
> +++ b/Makefile
> @@ -120,6 +120,7 @@ SCRIPTS = dtdiff
>  # We need both Python and swig to build pylibfdt.
>  .PHONY: maybe_pylibfdt
>  maybe_pylibfdt: FORCE
> +	if [ -n "${NO_PYTHON}" ]; then exit; fi; \

normally this is handled at the Makefile level, not inline in the script.
also, negative variables are messy.

what about:
PYTHON ?= y
ifeq ($(PYTHON),y)
all: maybe_pylibfdt
endif
-mike

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Device Tree]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux