On Fri, Feb 03, 2017 at 07:44:06PM +0000, Ian Campbell wrote: > On Thu, 2017-02-02 at 16:05 +1100, David Gibson wrote: > > Feel free to send a patch and I'll think about it. > > Please see below. > > The diffstat is a rather large due to the need to plumb `outname` > through to all the check functions. That could perhaps be avoided by > adding it to `struct dt_info *dti` instead since that is already > available in most places, but there would still be the churn relating > to adding a parameter to `check_msg` and the various wrapper macros. > Happy to rework along those lines if you prefer it though. I think putting the output name into dt_info would be nicer, yes. Make sure you allow for the case of output to stdout (which is default for -I dtb -O dts). -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
Attachment:
signature.asc
Description: PGP signature
