Re: [PATCH 1/1 v2] dtc: fdtdump: check fdt if not in scanning mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On 22 December 2016 at 12:59, Heinrich Schuchardt <xypron.glpk@xxxxxx> wrote:
> Running fdtdump without scan mode for an invalid file often
> results in a segmentation fault because the fdt header is
> not checked.
>
> With the patch the header is checked both in scanning as
> well as in non-scanning mode.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@xxxxxx>
> ---
>
> v2:
>         Refactor header check as separate function.
>
>  fdtdump.c | 27 +++++++++++++++++++--------
>  1 file changed, 19 insertions(+), 8 deletions(-)

Reviewed-by: Simon Glass <sjg@xxxxxxxxxxxx>

nit: I don't think the function needs to be marked 'inline'. It is not
time-critical.
--
To unsubscribe from this list: send the line "unsubscribe devicetree-compiler" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux