Hi David, On 17 November 2016 at 17:36, David Gibson <david@xxxxxxxxxxxxxxxxxxxxx> wrote: > On Thu, Nov 17, 2016 at 03:53:22PM -0700, Simon Glass wrote: >> Add Python bindings for a bare-bones set of libfdt functions. These allow >> navigating the tree and reading node names and properties. > > Nice idea. Some nits in the details.. > >> >> Signed-off-by: Simon Glass <sjg@xxxxxxxxxxxx> >> --- >> >> pylibfdt/.gitignore | 3 + >> pylibfdt/Makefile.pylibfdt | 21 ++++++ >> pylibfdt/libfdt.swig | 157 +++++++++++++++++++++++++++++++++++++++++++++ >> pylibfdt/setup.py | 34 ++++++++++ >> 4 files changed, 215 insertions(+) >> create mode 100644 pylibfdt/.gitignore >> create mode 100644 pylibfdt/Makefile.pylibfdt >> create mode 100644 pylibfdt/libfdt.swig >> create mode 100644 pylibfdt/setup.py >> >> diff --git a/pylibfdt/.gitignore b/pylibfdt/.gitignore >> new file mode 100644 >> index 0000000..5e8c5e3 >> --- /dev/null >> +++ b/pylibfdt/.gitignore >> @@ -0,0 +1,3 @@ >> +libfdt.py >> +libfdt.pyc >> +libfdt_wrap.c >> diff --git a/pylibfdt/Makefile.pylibfdt b/pylibfdt/Makefile.pylibfdt >> new file mode 100644 >> index 0000000..fbdbca5 >> --- /dev/null >> +++ b/pylibfdt/Makefile.pylibfdt >> @@ -0,0 +1,21 @@ >> +# Makefile.pylibfdt >> +# >> +# This is not a complete Makefile of itself. Instead, it is designed to >> +# be easily embeddable into other systems of Makefiles. > > So, Makefile.libfdt is explicitly designed for easily embedding libfdt > in other projecs - even ones with weird build environments, like > bootloaders. It's less clear that that's valuable for Python > wrappers. OK, but what should i do instead? Regards, Simon -- To unsubscribe from this list: send the line "unsubscribe devicetree-compiler" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
