On Thu, Oct 06, 2016 at 01:39:55PM +0200, Maxime Ripard wrote:
> Hi David,
>
> Here are a few patches to fix the things you requested and a few bugs
> encountered while doing so.
>
> Let me know what you think,
All applied, thanks.
Couple of other little errors to correct if you have time:
- BADOVERLAY is listed twice in the error string table (a hangover
from when there was both BADFIXUP and BADOVERLAY, I guess)
- The testcases re-use the same file name for the intermediate
dtbs. That's not a terrible problem, but it can make sorting out
what's going on when there are multiple errors in a test run
harder
- Generated dtb/dts files during the test should generally have a
.test.dtb / .test.dts extension (makes gitignores and clean targets
easier)
- In order for the apply_overlay function to be usable from the
libfdt shared library, you'll need to add it to version.lds
> Maxime
>
> Maxime Ripard (4):
> libfdt: Add BADPHANDLE error string
> libfdt: overlay: Report a bad overlay for mismatching local fixups
> libfdt: overlay: Fix symbols and fixups nodes condition
> tests: overlay: Move back the bad fixup tests
>
> libfdt/fdt_overlay.c | 9 +++++----
> libfdt/fdt_strerror.c | 1 +
> tests/run_tests.sh | 14 +++++++-------
> 3 files changed, 13 insertions(+), 11 deletions(-)
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
Attachment:
signature.asc
Description: PGP signature
