On Thu, Sep 01, 2016 at 08:08:21PM +0200, Danny Milosavljevic wrote:
> Hi,
>
> I'm packaging dtc for the GNU Guix distribution.
>
> In the process we found that Debian patches dtc 1.4.1 in order to add missing exports fdt_first_subnode, fdt_next_subnode, fdt_address_cells, fdt_size_cells, fdt_stringlist_contains, fdt_resize.
>
> Are these supposed to be exported?
Yes they are. In fact a patch already got merged upstream to add them
(and some others) to the version.lds - it just didn't go into a
release yet.
> If so, could you make a bugfix release tarball with just these
> added?
I packaged up a release with the latest git, including the export of
these symbols, and a handful of other small bugfixes.
>
> The patches are:
> >From a4b093f7366fdb429ca1781144d3985fa50d0fbb Mon Sep 17 00:00:00 2001
> From: Julien Grall <julien.grall@xxxxxxxxxx>
> Date: Tue, 17 Mar 2015 16:00:34 +0000
> Subject: [PATCH] libfdt: Add missing functions to shared library
>
> The commit 4e76ec7 "libfdt: Add fdt_next_subnode() to permit easy
> subnode iteration" adds new functions (fdt_{first,next}_subnode) but
> forgot to mark them as 'global' in the shared library.
>
> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> ---
> libfdt/version.lds | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/libfdt/version.lds b/libfdt/version.lds
> index 80b322b..941208e 100644
> --- a/libfdt/version.lds
> +++ b/libfdt/version.lds
> @@ -54,6 +54,8 @@ LIBFDT_1.2 {
> fdt_get_property_by_offset;
> fdt_getprop_by_offset;
> fdt_next_property_offset;
> + fdt_first_subnode;
> + fdt_next_subnode;
>
> local:
> *;
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
Attachment:
signature.asc
Description: PGP signature
