On Thu, Jul 14, 2016 at 10:02:31AM +0000, Wang Tim（王艇艇） wrote: > Hi David, > Thanks for your review! > > I'll add the "actually check" code about the new dtb file with alignment option. > And add more case which combine with other options. > > BTW, do I need combine the test patch and "-a option" into one > patch? Either way is ok. Since they're both fairly small, it's probably simpler to combine them. > > Best Regards > Tim Wang(王艇艇) > > > -----Original Message----- > From: David Gibson [mailto:david@xxxxxxxxxxxxxxxxxxxxx] > Sent: Thursday, July 14, 2016 5:27 PM > To: Wang Tim（王艇艇） > Cc: devicetree-compiler@xxxxxxxxxxxxxxx; wtt_usst@xxxxxxx > Subject: Re: [PATCH] tests: add -a option cases > > On Wed, Jul 13, 2016 at 07:35:01PM +0800, Tim Wang wrote: > > Signed-off-by: Tim Wang <timwang@xxxxxxxxxxxx> > > This is a good start. However it needs some more. > > First, you should have some tests which actually check that the generated blobs have the correct alignment. > > Second, you should check more than just one alignment. > > > --- > > tests/run_tests.sh | 7 ++++--- > > 1 file changed, 4 insertions(+), 3 deletions(-) > > > > diff --git a/tests/run_tests.sh b/tests/run_tests.sh index > > 7eb9b3d..6aed6d6 100755 > > --- a/tests/run_tests.sh > > +++ b/tests/run_tests.sh > > @@ -579,9 +579,10 @@ fdtput_tests () { > > dts=label01.dts > > dtb=$dts.fdtput.test.dtb > > text=lorem.txt > > + align=64 > > > > # Allow just enough space for $text > > - run_dtc_test -O dtb -p $(stat -c %s $text) -o $dtb $dts > > + run_dtc_test -O dtb -p $(stat -c %s $text) -a $align -o $dtb $dts > > > > # run_fdtput_test <expected-result> <file> <node> <property> <flags> <value> > > run_fdtput_test "a_model" $dtb / model -ts "a_model" > > @@ -600,7 +601,7 @@ fdtput_tests () { > > run_fdtput_test "$(cat $text $text)" $dtb /randomnode blob -ts "$(cat $text $text)" > > > > # Start again with a fresh dtb > > - run_dtc_test -O dtb -p $(stat -c %s $text) -o $dtb $dts > > + run_dtc_test -O dtb -p $(stat -c %s $text) -a $align -o $dtb $dts > > > > # Node creation > > run_wrap_error_test $DTPUT $dtb -c /baldrick sod @@ -628,7 +629,7 > > @@ fdtput_tests () { > > run_wrap_test $DTPUT $dtb -cp /chosen/son > > > > # Start again with a fresh dtb > > - run_dtc_test -O dtb -p $(stat -c %s $text) -o $dtb $dts > > + run_dtc_test -O dtb -p $(stat -c %s $text) -a $align -o $dtb $dts > > > > # Node delete > > run_wrap_test $DTPUT $dtb -c /chosen/node1 /chosen/node2 > > /chosen/node3 > -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
Attachment:
signature.asc
Description: PGP signature
