On Fri, Jun 10, 2016 at 05:03:36PM +0300, Pantelis Antoniou wrote: > Hi Maxime, > > > On May 27, 2016, at 12:13 , Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx> wrote: > > > > The libfdt overlay support introduces a bunch of new includes and > > functions. > > > > Make sure we are able to build it by adding the needed glue. > > > > Signed-off-by: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx> > > --- > > include/libfdt_env.h | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/include/libfdt_env.h b/include/libfdt_env.h > > index 273b5d30f867..2d2196031332 100644 > > --- a/include/libfdt_env.h > > +++ b/include/libfdt_env.h > > @@ -23,6 +23,13 @@ typedef __be64 fdt64_t; > > #define fdt64_to_cpu(x) be64_to_cpu(x) > > #define cpu_to_fdt64(x) cpu_to_be64(x) > > > > +#ifdef __UBOOT__ > > +#include "malloc.h" > > +#include "vsprintf.h" > > + > > +#define strtol(cp, endp, base) simple_strtol(cp, endp, base) > > +#endif > > + > > /* adding a ramdisk needs 0x44 bytes in version 2008.10 */ > > #define FDT_RAMDISK_OVERHEAD 0x80 > > > > We need to figure out what the upstream libfdt/dtc maintainer’s take is on this is. > For u-boot we’re fine and for now it’s OK. These were sent to the upstream dtc list as well. The concept is fine, but there are a number of problems in the implementation. I sent detailed review comments on the upstream versions, haven't seen a respin yet. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
Attachment:
signature.asc
Description: PGP signature
