Re: [PATCH] Remove duplicated -Werror in dtc Makefile

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On Tue, Nov 03, 2015 at 01:02:00PM +0100, Thomas Huth wrote:
> The "-Werror" compiler flag is currently declared twice in the
> Makefile, one time in WARNINGS, and one time in CFLAGS. Let's
> remove one of them.
> 
> Signed-off-by: Thomas Huth <thuth@xxxxxxxxxx>

Applied, thanks.  However, I moved the remaining -Werror from WARNINGS
to CFLAGS - the idea is that WARNINGS controls just which warnings are
enabled, wheres -Werror controls what happens when a warning occurs.

> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index c1d0757..75ab67e 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -18,7 +18,7 @@ CONFIG_LOCALVERSION =
>  CPPFLAGS = -I libfdt -I .
>  WARNINGS = -Werror -Wall -Wpointer-arith -Wcast-qual -Wnested-externs \
>  	-Wstrict-prototypes -Wmissing-prototypes -Wredundant-decls -Wshadow
> -CFLAGS = -g -Os -fPIC -Werror $(WARNINGS)
> +CFLAGS = -g -Os -fPIC $(WARNINGS)
>  
>  BISON = bison
>  LEX = flex

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Device Tree]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux