On Tue, Sep 29, 2015 at 03:53:13PM +1000, David Gibson wrote: > On Thu, Jul 16, 2015 at 01:10:19PM +0200, Thierry Reding wrote: > > From: Thierry Reding <treding@xxxxxxxxxx> > > > > Given a device tree node and a property name, the fdt_count_strings() > > function counts the number of strings found in the property value. > > > > This also adds a new error code, FDT_ERR_BADVALUE, that the function > > returns when it encounters a non-NUL-terminated string list. > > > > Signed-off-by: Thierry Reding <treding@xxxxxxxxxx> > > --- > > Changes in v2: > > - return FDT_ERR_BADVALUE error code for non-NUL-terminated properties > > - add tests to cover non-NUL-terminated properties > > This looks good, except for the function name. I'd prefer to see it > called 'fdt_stringlist_count()' to match the existing > 'fdt_stringlist_contains()'. Done. Thierry
Attachment:
signature.asc
Description: PGP signature
