On Wed, Jun 18, 2014 at 08:01:48PM +0300, Andrei Errapart wrote:
>
> commit b8ad167d89d7f5ba6398ffeab6a7f9ece954f208
> Author: Andrei Errapart <andrei@xxxxxxxxxxxxxxxxxxxxxxx>
> Date: Wed Jun 18 18:43:17 2014 +0200
>
> * MSVC doesn't support 0-sized arrays.
Ugh, this is by far the ugliest of these workarounds, and the reason
for it in the code is really non-obvious. I'll have to think about
this some more.
> * Initialize check->inprogress, too.
Why..?
> Signed-off-by: Andrei Errapart <andrei@xxxxxxxxxxxxxxxxxxxxxxx>
I've applied patches 2, 3, and 4. But for future reference, please remember:
* Patches should be inline, not attachments
* Commit message and signed-off-by lines should not be indented
* Commit messages need more details on the reason for the patch (see
the changes I've made for examples).
* Commit messages need a 1 line summary at the top (2, 3, and 4 have
this, but 1 doesn't)
* There should be a blank line between the 1-lite summary and the
remainder of the commit message
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
Attachment:
pgpAchqbjV8L7.pgp
Description: PGP signature
