On Mon, Jun 16, 2014 at 11:35:50AM -0500, Jack Miller wrote: > - Tweaked patch description to make failing case clearer > - Added test > > I decided to only test the mangled output since realloc was just a more serious > and obvious symptom of the same problem. I also verified that the pre-patch dtc > does in fact fail the test. > > Let me know if there's anything else that needs to be done. Sure, couple of nits to pick. It's preferred to fold fix and testcase into the same patch - particularly for small fixes like this. Further comment against the individual patches. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
Attachment:
pgpLrYQaxhSq7.pgp
Description: PGP signature
