Re: [PATCH] Properly handle \0 delimited string lists

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



Hi Jack,

Long time no see :).

On Tue, Jun 10, 2014 at 02:57:36PM -0500, Jack Miller wrote:
> reserved-names="res1\0res2\0res3";
> 
> Is valid DTS. This one-liner expands data based on the len given by the lexer
> instead of strlen.
> 
> Without this patch, realloc gets confused and hangs. For example:
> 
> *** Error in `./dtc': realloc(): invalid next size: 0x0000000001961670
> ***

So.. the patch certainly isn't wrong, and is arguably safer than the
current version.

But.. I haven't been able to reproduce the problem, and I don't really
see how it would occur in the first place.

The thing we're taking a strlen of is the input with it's escapes, so
it won't have NULs, just backslashes and 0 digits.

Or am I missing something?

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

Attachment: pgpwg9EvWdGV4.pgp
Description: PGP signature


[Index of Archives]     [Device Tree]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux